Fix Feed state not fully cleared on feed deleted #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the feed state was not being completely cleared when a feed is deleted, ensuring all stateful properties are properly reset.
Key Changes:
- Added clearing of
aggregatedActivities,pinnedActivities,notificationStatus, andactivitiesPaginationin theonFeedDeleted()method - Updated the test to verify these additional state properties are cleared
- Changed test assertions from
assertEquals(emptyList<T>(), ...)toassertTrue(...isEmpty())for cleaner readability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| FeedStateImpl.kt | Added clearing of previously missed state properties (aggregatedActivities, pinnedActivities, notificationStatus, activitiesPagination) in the onFeedDeleted() method |
| FeedStateImplTest.kt | Enhanced test coverage for onFeedDeleted() to verify all state properties are cleared, including the newly added ones |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...oid-client/src/main/kotlin/io/getstream/feeds/android/client/internal/state/FeedStateImpl.kt
Show resolved
Hide resolved
gpunto
force-pushed
the
fully-clear-fid-state-on-deletion
branch
from
80b3048 to
ffc88a6
Compare
|
VelikovPetar
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We're not fully clearing the state on feed deleted, but we should.
Implementation
Clear state that we were not clearing.
Testing
Not sure how feasible this is to do manually, but you'd have to observe all properties of a
Feed, then delete it and verify they're all reset.Checklist